App dependencies are now analysed on app enable as well - not only on app install. #26295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @icewind1991 and @nickvergessen to be potential reviewers. |
|
Tested by enabling on the CLI with mismatch requirements because the web UI doesn't allow it. Works 👍 |
|
I'd say backport to 9.1 but no further, unless really critical |
DeepDiver1975
pushed a commit
that referenced
this pull request
Oct 12, 2016
…ies-on-app-enable-as-well App dependencies are now analysed on app enable as well - not only on app install.
DeepDiver1975
pushed a commit
that referenced
this pull request
Oct 13, 2016
…ies-on-app-enable-as-well App dependencies are now analysed on app enable as well - not only on app install.
PVince81
pushed a commit
that referenced
this pull request
Oct 17, 2016
…553c363bf9594a044f302 [stable9.1] Merge pull request #26295 from owncloud/analyse-dependenc…
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
App dependencies can now evaluated on enable as well.
Motivation and Context
Let's say the system environment was okay on installation of an app.
Then the app is disabled for some time and in between the system environment is changed.
After re-enabling the app we would render the system unstable.
How Has This Been Tested?
Add a dependency to an installed but disabled app - e.g.
Now enable the app and see it fail
Types of changes
Checklist: